Allow F_CPU redefinition #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid any issue with `F_CPU` value, it is defined by default to `SystemCoreClock` value which is updated automatically after each clock configuration update. Some libraries use `F_CPU` at build time for conditional purpose (ex to stm32duino#612). This commit allow to redefine it at build time using `build_opt.h` or `hal_conf_extra.h`: https://github.com/stm32duino/wiki/wiki/Custom-definitions then it will be possible to define it as a constant. Important note: **User have to ensure to set it to the proper value.** Signed-off-by: Frederic.Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any issue with
F_CPUvalue, it is defined by default toSystemCoreClockvalue which is updated automatically after eachclock configuration update.
Some libraries use
F_CPUat build time for conditional purpose (ex to #612).This commit allow to redefine it at build time using
build_opt.horhal_conf_extra.h:https://github.com/stm32duino/wiki/wiki/Custom-definitions
then it will be possible to define it as a constant.
Important note:
User have to ensure to set it to the proper value.